Support multiple RPCs parsing in wireshark dissector for baidu_std protocol#2710
Merged
Conversation
Contributor
|
@wasphin 有空看看 |
Member
|
@AnDiXL 能不能帮传个多 RPC 请求响应的抓包看下？ |
wasphin
approved these changes
Jul 28, 2024
wasphin
left a comment
wasphin
left a comment
Member
There was a problem hiding this comment.
LGTM
目前 wireshark protobuf 中提供了不同类型 field 的值列表，但是较难跟 proto 中的 field 对应上，后面可以再看看 wireshark 中能不能做些调整。
| @@ -237,6 +275,8 @@ dissect_proto = function(tvbuf, pktinfo, root, offset) | |||
| method_name = protobuf_field_values[k].range:string(ENC_UTF8) | |||
| elseif v.value == "correlation_id" then | |||
| correlation_id = protobuf_field_values[k].range:uint64() | |||
Member
There was a problem hiding this comment.
这里的值也是错的， 只不过目前只是作为 key 来用，没影响。
Contributor
Author
There was a problem hiding this comment.
这里的值也是错的， 只不过目前只是作为 key 来用，没影响。
是的，这里其实跟attachment_size是一样的，如果需要拿到真实的correlation_id值，同样要经过le_uint & 反序列化的操作，只是当前用不到
Contributor
Author
嗯，已经私发 |
chenBright
pushed a commit
to chenBright/brpc
that referenced
this pull request
Aug 1, 2024
…otocol (apache#2710) Co-authored-by: xulei25 <xulei25@baidu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…otocol
What problem does this PR solve?
Issue Number: resolve #2408
Problem Summary:
What is changed and the side effects?
原本 tools/wireshark_baidu_std.lua 的实现存在两个问题：
Changed:
修复 #2408 引入的wireshark dissector无法解析包含多个baidu_std protocol请求的报文的问题。
Side effects:
Performance effects(性能影响):无
Breaking backward compatibility(向后兼容性): yes
Check List: